Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode '/' in prop name #1834

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Encode '/' in prop name #1834

merged 2 commits into from
Feb 4, 2022

Conversation

max-elia
Copy link
Contributor

@max-elia max-elia commented Nov 16, 2021 •
edited
Loading

  • Encode '/' in ui schema generator
  • Decode '/' and '~' in:
    • Resolvers
    • Label
    • MaterialTableControl
    • Vanilla TableArrayControl
    • Angular table.renderer
  • Add test cases for uischema, resolver and path

Signed-off-by: Max Elia Schweigkofler max_elia@hotmail.de

@coveralls
Copy link

coveralls commented Nov 16, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 84.29% when pulling 40b2367 on max-elia:prop-name-encoding into 8c3b626 on eclipsesource:master.

@sdirix sdirix requested a review from TheZoker November 30, 2021 08:36
TheZoker
TheZoker suggested changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@TheZoker TheZoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍
For most cases this works well, but as soon as there is an array involved , there seems to be no input anymore:
image

image

@sdirix sdirix mentioned this pull request Jan 3, 2022
Closed
@max-elia
Encoding of special characters in prop name
be63a89 
- Encode '/' in ui schema generator
- Decode '/' and '~' in:
  - Resolvers
  - Label
  - MaterialTableControl
  - Vanilla TableArrayControl
  - Angular table.renderer
- Add test cases for uischema, resolver and path

Signed-off-by: Max Elia Schweigkofler <max_elia@hotmail.de>
@max-elia
Copy link
Contributor Author

max-elia commented Jan 19, 2022 •
edited
Loading

Thanks, for the feedback. Arrays now also work fine and tests have been added.

TheZoker
TheZoker approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@TheZoker TheZoker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Array example works now

sdirix
sdirix approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sdirix sdirix merged commit d65d7eb into eclipsesource:master Feb 4, 2022
@sdirix sdirix mentioned this pull request Jun 8, 2022
Closed
@sdirix sdirix mentioned this pull request Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

@TheZoker TheZoker TheZoker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@max-elia @coveralls @TheZoker @sdirix