Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uischemas to dependency array #1836

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

TheZoker
Copy link
Contributor

@TheZoker TheZoker commented Nov 16, 2021

Currently the uischema prop of JSONForms was not watched for changes. So when uischemas was changed after JSONForms was rendered, the change did not get applied

@TheZoker TheZoker marked this pull request as draft November 16, 2021 14:46
@coveralls
Copy link

coveralls commented Nov 16, 2021

Coverage Status

Coverage decreased (-0.03%) to 89.345% when pulling 9085c07 on TheZoker:add-uischemas-dependency into 7532a3e on eclipsesource:master.

@TheZoker TheZoker marked this pull request as ready for review November 16, 2021 15:21
Currently the uischema prop of JSONForms was not watched for changes. So when uischemas was changed after JSONForms was rendered, the change did not get applied
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sdirix sdirix merged commit 6bcdbb1 into eclipsesource:master Nov 22, 2021
@sdirix sdirix added this to the 3.0 milestone Nov 22, 2021
@sdirix sdirix added the react label Nov 22, 2021
@TheZoker TheZoker deleted the add-uischemas-dependency branch November 22, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants