Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customizable CSS classes to vanilla radio group #1843

Conversation

andresgutgon
Copy link
Contributor

What?

Fix this issue: #1842

@CLAassistant
Copy link

CLAassistant commented Dec 5, 2021

CLA assistant check
All committers have signed the CLA.

@sdirix
Copy link
Member

sdirix commented Dec 6, 2021

Thanks for the PR including test cases. We'll take a look soon!

@coveralls
Copy link

coveralls commented Dec 6, 2021

Coverage Status

Coverage remained the same at 85.447% when pulling 3196051 on andresgutgon:feature/add-css-classes-to-radio-group-input into d5a9038 on eclipsesource:master.

@andresgutgon
Copy link
Contributor Author

andresgutgon commented Dec 9, 2021

Hi @sdirix were you be able to take a look into this? Thanks!

@andresgutgon andresgutgon force-pushed the feature/add-css-classes-to-radio-group-input branch from 149d1a4 to 3196051 Compare December 9, 2021 08:34
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@sdirix sdirix merged commit 7363465 into eclipsesource:master Dec 9, 2021
@sdirix sdirix added this to the 3.0 milestone Dec 9, 2021
@sdirix sdirix linked an issue Dec 9, 2021 that may be closed by this pull request
@sdirix sdirix removed this from the 3.0 milestone Dec 9, 2021
@andresgutgon andresgutgon deleted the feature/add-css-classes-to-radio-group-input branch December 9, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom CSS classes to RadioGroup
4 participants