Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass as UISchema options placeholder attribute for TextCell and TextAreaCell cells #1844

Conversation

andresgutgon
Copy link
Contributor

What?

Solve this issue #1840

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good and thanks for adding the test cases!

I only have minor comments.

packages/examples/src/day2.ts Outdated Show resolved Hide resolved
packages/vanilla/src/cells/TextAreaCell.tsx Outdated Show resolved Hide resolved
@andresgutgon andresgutgon force-pushed the feature/pass-placeholder-attribute-to-text-and-textarea-react-cells branch from 72fbf0e to 572beb2 Compare December 6, 2021 09:01
@andresgutgon
Copy link
Contributor Author

Comments fixed : )

@coveralls
Copy link

coveralls commented Dec 6, 2021

Coverage Status

Coverage increased (+0.005%) to 89.391% when pulling 572beb2 on andresgutgon:feature/pass-placeholder-attribute-to-text-and-textarea-react-cells into 6bcdbb1 on eclipsesource:master.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@sdirix sdirix merged commit d5a9038 into eclipsesource:master Dec 7, 2021
@sdirix sdirix added this to the 3.0 milestone Dec 7, 2021
@andresgutgon andresgutgon deleted the feature/pass-placeholder-attribute-to-text-and-textarea-react-cells branch December 7, 2021 07:57
@andresgutgon
Copy link
Contributor Author

yay! thanks to you : )

@andresgutgon
Copy link
Contributor Author

When something is merged is pushed to npm or do you have release days?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants