-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type-imports according to the release notes of TypeScript 3.8 #1845
Conversation
Hi @mirismaili, thanks for the PR. Can you tell about the motivation? Do you run into problems when not refactoring those specific type imports/exports? |
Hi @sdirix Your welcome. I am trying to add some unsupported features to the library ( My different webpack/typescript configuration (at the dev-project) caused some issues. I fixed them (there) to match JSONForms. But this special case was an issue in JSONForms. So I decided to fix it here. |
I think the below configuration can be changed after this fix (be applied to all packages): jsonforms/webpack/webpack.base.js Line 25 in 6bcdbb1
But I'm not sure. |
@mirismaili The PR conflicts now, can you rebase on latest master? |
5de6d92
to
7ec1e95
Compare
@sdirix |
e1bebab
to
8fab66b
Compare
8fab66b
to
779e05e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
See: Type-Only Imports and Export