Build ESM and CommonJS modules #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 22, 2021
Closed
AlexandraBuzila
approved these changes
Dec 22, 2021
Use Rollup to bundle ESM and CommonJS modules for all non-Angular packages. Angular builds are done via ngc. ESM bundles target 'esnext' while CommonJS bundles continue to target ES5. Also adjusts Vue dependencies so that Vue and the respective template compiler are of the same version.
As '@mui/lab' is now a core dependency we no longer need to maintain two different renderer sets. The autocomplete renderers are now part of the normal renderer set.
Updates nyc and IstanbulJS to make the CI code coverage measurement less error prone. Also increase Node version in CI builds to 14 and skip tests on MacOS for now as the cross environment variables don't seem to properly work there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Rollup to bundle ESM and CommonJS modules for all non-Angular
packages. Angular builds are done via ngc.
ESM bundles target 'esnext' while CommonJS bundles continue to
target ES5.
Also adjusts Vue dependencies so that Vue and the respective
template compiler are of the same version.
Also removes the React Material extended renderer set