Use validationError classes defined in styles. This way this can be ovewriten by users #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgutgon
commented
Jan 10, 2022
overriten by users
andresgutgon
force-pushed
the
fix/use-validationError-class-on-radio-buttons
branch
from
88b2e6b
to
0f09faf
Compare
andresgutgon
commented
Jan 10, 2022
| const divClassNames = `validation ${isValid ? classNames.description : 'validation_error' }`; | ||
| const divClassNames = [classNames.validation] | ||
| .concat(isValid ? classNames.description : classNames.validationError) | ||
| .join(' '); |
There was a problem hiding this comment.
Do the same as in the input control
|
Thanks for this contribution too 😉 We'll take a look very soon! |
sdirix
approved these changes
Jan 11, 2022
andresgutgon
deleted the
fix/use-validationError-class-on-radio-buttons
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This one is pretty easy. In text inputs errors can be styled.
Example in my code
But Radio buttons have a hardcoded string so is not possible.
Solution
Just use the prop we have for this clase