Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Angular packages #1869

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Update Angular packages #1869

merged 1 commit into from
Jan 17, 2022

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented Jan 14, 2022

  • Fixes the module declaration in @jsonforms/angular so the ESM
    build can be picked up reliably
  • Exports all functions used in Angular components to avoid
    name clashes by the ngc transpiler
  • Removes the redundant zonejs peer dependency
  • Indicate compatibility with Angular 13
  • Adapts i18n change detection to allow updating i18n via the
    JsonFormsAngularService independent from the root component
    props

- Fixes the module declaration in @jsonforms/angular so the ESM
  build can be picked up reliably
- Exports all functions used in Angular components to avoid
  name clashes by the ngc transpiler
- Removes the redundant zonejs peer dependency
- Indicate compatibility with Angular 13
- Adapts i18n change detection to allow updating i18n via the
  JsonFormsAngularService independent from the root component
  props
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.242% when pulling 1008469 on sdirix:fix-angular into 95018ca on eclipsesource:master.

@sdirix
Copy link
Member Author

sdirix commented Jan 17, 2022

Hi @ttr7usb! Thanks for taking a look. Did you test the changes? What exactly did you test?

Copy link
Member

@AlexandraBuzila AlexandraBuzila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes LGTM. I did not test them however.

@sdirix sdirix merged commit ea6fe82 into eclipsesource:master Jan 17, 2022
@sdirix sdirix deleted the fix-angular branch January 17, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

angular 12 does not compile with 3.0.0-beta.0 Angular 13 support
4 participants