Update readmes for 3.0 #1875
Merged
Update readmes for 3.0 #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasBoll
force-pushed
the
update_readme
branch
from
eac49cb
to
081e76c
Compare
LukasBoll
force-pushed
the
update_readme
branch
from
081e76c
to
38c9dc6
Compare
LukasBoll
force-pushed
the
update_readme
branch
from
38c9dc6
to
a137a24
Compare
sdirix
requested changes
Apr 7, 2022
added link to migrationguide closes eclipsesource#1852 Signed-off-by: Lukas Boll lukas-bool@web.de
LukasBoll
force-pushed
the
update_readme
branch
from
be05e6b
to
35aa4b0
Compare
There was a problem hiding this comment.
LGTM overall. I have some very minor remarks.
In the root README line 12, I would replace
- Install dependencies with
npm ci(ornpm installwhen using an older version)
with:
- Install dependencies with
npm ci
As the JSONForms build does not work with node versions older than 14 (which includes npm 6), JSONForms cannot be built with an npm version not supporting the ci command
Co-authored-by: Lucas Koehler <lkoehler@eclipsesource.com>
sdirix
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update readmes for 3.0
added link to migrationguide
closes #1852
Signed-off-by: Lukas Boll lukas-bool@web.de