Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve enum labels in React Material enum array #1904

Merged
merged 2 commits into from
May 5, 2022
Merged

Preserve enum labels in React Material enum array #1904

merged 2 commits into from
May 5, 2022

Conversation

JoshuaFortriede
Copy link
Contributor

use of lodash startCase was changing the values of enum values used a labels. Removed function and import.

use of lodash startCase was changing the values of enum values used a labels. Removed function and import.
@CLAassistant
Copy link

CLAassistant commented Mar 26, 2022

CLA assistant check
All committers have signed the CLA.

@sdirix sdirix self-requested a review March 29, 2022 08:49
@sdirix
Copy link
Member

sdirix commented Apr 6, 2022

Hi @JoshuaFortriede! Thanks for the pull request! Are you able to also fix the now failing test cases?

@sdirix sdirix linked an issue Apr 7, 2022 that may be closed by this pull request
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.29% when pulling 3074e33 on JoshuaFortriede:fix/enum_array_label_display_#1903 into d65d7eb on eclipsesource:master.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@sdirix sdirix merged commit d04e851 into eclipsesource:master May 5, 2022
@sdirix sdirix added this to the 3.0 milestone May 5, 2022
@sdirix sdirix changed the title remove lodash startCase from label of checkboxes #1903 Preserve enum labels in React Material enum array May 5, 2022
@sdirix sdirix removed this from the 3.0 milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove startCase from label in MaterialEnumArrayRenderer.tsx
5 participants