(vue) add binding for one enum cell elements #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Just a note in case it's helpful to you - there is also a Vue/Vuetify renderer set in development (though usable now) over at https://github.com/eclipsesource/jsonforms-vuetify-renderers |
sdirix
requested changes
Apr 27, 2022
There was a problem hiding this comment.
Hi @jdwit,
Thank you very much for the PR! In general we're definitely interested in any improvements to our bindings and renderers. If you want to tackle something which requires more effort and you want to be certain that we'll actually merge it, I would like to recommend to open a feature request first, describe your planned implementation and wait for our feedback.
However things like this which is just a missing binding certainly don't require a previous discussion ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The control bindings for Vue where missing the one for cells with a
oneOfschema; nooptionsprop was generated. For control bindings this is present, this PR adds the binding for cells. If you have any feedback please let me know, I would like to contribute more in the future since we are investing in this project for our application that will soon be in production.