Integrate external errors in form #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandraBuzila
force-pushed
the
additional-errors
branch
from
9584e7e
to
fc54e9a
Compare
sdirix
requested changes
May 20, 2022
packages/core/src/reducers/core.ts
Outdated
| ) => (state: JsonFormsCore): ErrorObject[] => { | ||
| const errors = state.errors ?? []; | ||
| const additionalErrors = state.additionalErrors ?? []; | ||
| return errorsAt(instancePath, schema, matchPath)(state.validationMode === 'ValidateAndHide' ? [...additionalErrors] : [...errors, ...additionalErrors]); |
There was a problem hiding this comment.
Suggested change
| return errorsAt(instancePath, schema, matchPath)(state.validationMode === 'ValidateAndHide' ? [...additionalErrors] : [...errors, ...additionalErrors]); | |
| return errorsAt(instancePath, schema, matchPath)(state.validationMode === 'ValidateAndHide' ? additionalErrors : [...errors, ...additionalErrors]); |
Add support for specifying external errors via `additionalErrors: ajv.ErrorObject[]` prop. The additional errors are merged with the validation errors and are supplied to the affected controls. The additional errors are not affected by the validationMode like the validation errors are and it is the responsability of the framework user to update the prop when applicable (e.g. on ValidationMode changes). Fixes eclipsesource#1926 Contributed on behalf of STMicroelectronics Signed-off-by: Alexandra Buzila <abuzila@eclipsesource.com>
AlexandraBuzila
force-pushed
the
additional-errors
branch
from
fc54e9a
to
fb89b1e
Compare
|
Thank you for the review, Stefan! I updated the code and added examples for React (material and vanilla) and vue-vanilla. The contributed example should work with the angular examples as well when they'll support displaying buttons for the contributed actions like the React app (it's currently not the case). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for specifying external errors via
additionalErrors: ajv.ErrorObject[]prop.The additional errors are merged with the validation errors and are
supplied to the affected controls. The additional errors are not
affected by the validationMode like the validation errors are and it is
the responsability of the framework user to update the prop when
applicable (e.g. on ValidationMode changes).
Fixes #1926
Contributed on behalf of STMicroelectronics