Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add errors parameter to translation function #1939

Merged
merged 1 commit into from
May 23, 2022
Merged

add errors parameter to translation function #1939

merged 1 commit into from
May 23, 2022

Conversation

LukasBoll
Copy link
Contributor

Signed-off-by: Lukas Boll lukas-bool@web.de

@coveralls
Copy link

coveralls commented May 20, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 84.29% when pulling 3d47d04 on LukasBoll:translation_errors into 8026ada on eclipsesource:master.

sdirix
sdirix requested changes May 20, 2022
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if we always hand over an object for the 3rd parameter. Then we can easily add additional parameters later on and users don't need to type check.

packages/core/src/i18n/i18nUtil.ts Outdated Show resolved Hide resolved
packages/core/src/util/renderer.ts Outdated Show resolved Hide resolved
@LukasBoll
add errors parameter to translation function
3d47d04 
Signed-off-by: Lukas Boll lukas-bool@web.de
sdirix
sdirix approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdirix sdirix merged commit 8dc8751 into eclipsesource:master May 23, 2022
@sdirix sdirix linked an issue May 23, 2022 that may be closed by this pull request
Translation Values #1930
Closed
@sdirix sdirix mentioned this pull request May 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translation Values
3 participants
@LukasBoll @coveralls @sdirix