Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly determine UI Schemas #1940

Merged
merged 1 commit into from
May 24, 2022

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented May 23, 2022

Always hand over as many parameters as applicable to the "findUISchema" utility. This
makes sure that all available options are considered in all cases. For example this fixes
an issue in the Vue bindings in which "options.detail" UI Schemas were ignored.

Always hand over as many parameters as applicable to the "findUISchema" utility. This
makes sure that all available options are considered in all cases. For example this fixes
an issue in the Vue bindings in which "options.detail" UI Schemas were ignored.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.29% when pulling 91913fc on sdirix:fix-uischema-determinations into 8dc8751 on eclipsesource:master.

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, thanks! I explicitly tested the vue case of the linked issue and it now uses the provided detail schema as expected :)

@sdirix sdirix merged commit 44070b3 into eclipsesource:master May 24, 2022
@sdirix sdirix deleted the fix-uischema-determinations branch May 24, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue Vanilla Array binding doesn't properly determine the UI Schema of its elements
3 participants