Pass all props in the MaterialArrayLayoutRenderer #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdirix
requested changes
Jun 8, 2022
Currently the MaterialArrayLayoutRenderer only hands over a selected list of props to the MaterialArrayLayout component it wraps. This is now refactored to hand over all incoming props. This fixes the issue that the 'config' prop was previously not handed over. Contributed on behalf of STMicroelectronics
sdirix
force-pushed
the
fix/materialarraylayout-sort
branch
from
f91ab22
to
7b48965
Compare
sdirix
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the MaterialArrayLayoutRenderer lists the props explicitly,
this way the config was forgotten and thus the
move up/down buttons cannot be enabled globally using the config object.
Contributed on behalf of STMicroelectronics