Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React Vanilla enum renderer removes empty data #1961

Merged
merged 1 commit into from
Jun 26, 2022
Merged

React Vanilla enum renderer removes empty data #1961

merged 1 commit into from
Jun 26, 2022

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented Jun 21, 2022

Instead of the empty string the React Vanilla enum renderer will now hand over
'undefined' to handleChange and therefore delete the corresponding attribute.

Fixes #1959

@sdirix
React Vanilla enum renderer removes empty data
18bf2f6 
Instead of the empty string the React Vanilla enum renderer will now hand over
'undefined' to handleChange and therefore delete the corresponding attribute.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.098% when pulling 18bf2f6 on sdirix:vanilla-enum-renderer-empty into 31972a5 on eclipsesource:master.

@LukasBoll
Copy link
Contributor

Looks good to me!

@sdirix sdirix merged commit 146415b into eclipsesource:master Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vanilla enum renderer should store undefined instead of empty string
3 participants
@sdirix @coveralls @LukasBoll