Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix React Vanilla time renderer format #1962

Merged
merged 1 commit into from
Jun 26, 2022

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented Jun 21, 2022

JSON Schema's time format is specified as 'HH:mm:ss'. The React Vanilla time renderer
is adjusted to store in this format by appending ':00' when necessary.

Fixes #1958

JSON Schema's time format is specified as 'HH:mm:ss'. The React Vanilla time renderer
is adjusted to store in this format by appending ':00' when necessary.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.098% when pulling 55ae3b1 on sdirix:fix-vanilla-time-renderer into 31972a5 on eclipsesource:master.

@LukasBoll
Copy link
Contributor

Looks good to me!

@sdirix sdirix merged commit b3e6d89 into eclipsesource:master Jun 26, 2022
@sdirix sdirix deleted the fix-vanilla-time-renderer branch June 26, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vanilla time renderer stores invalid time
3 participants