Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ExampleDescription with optional i18n configuration #1974

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

lucas-koehler
Copy link
Contributor

  • Extend the ExampleDescription to allow configuring i18n for examples
  • Adapt example apps to use a provided i18n config
  • Add i18n configuration to the categorization and Person (i18n) examples

* Extend the ExampleDescription to allow configuring i18n for examples
* Adapt example apps to use a provided i18n config
* Add i18n configuration to the `categorization` and `Person (i18n)` examples
@lucas-koehler lucas-koehler requested a review from sdirix July 7, 2022 10:39
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.259% when pulling 71c11fa on lucas-koehler:examples-support-i18n into 6a6af7e on eclipsesource:master.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdirix sdirix merged commit 0bb0592 into eclipsesource:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants