Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark compatible with Angular 14 #1979

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Mark compatible with Angular 14 #1979

merged 2 commits into from
Jul 15, 2022

Conversation

TheZoker
Copy link
Contributor

Mark JSONForms compatible with Angular 14.

Was tested within the angular-seed and everything worked.

@coveralls
Copy link

coveralls commented Jul 15, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 84.259% when pulling ed6d8ec on TheZoker:angular-14-compatible into 6a6af7e on eclipsesource:master.

sdirix
sdirix requested changes Jul 15, 2022
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also mark the Angular dependencies in other packages (especially @jsonforms/angular-material) as compatible to Angular 14

@TheZoker TheZoker requested a review from sdirix July 15, 2022 14:06
sdirix
sdirix approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdirix sdirix merged commit 70f61db into eclipsesource:master Jul 15, 2022
@sdirix sdirix linked an issue Jul 15, 2022 that may be closed by this pull request
Angular 14 compatibility? #1973
Closed
@sdirix sdirix mentioned this pull request Jul 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Angular 14 compatibility?
3 participants
@TheZoker @coveralls @sdirix