Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize arrays with union type items as nested object arrays again #2000

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

lucas-koehler
Copy link
Contributor

Adapts the isObjectArrayWithNesting tester to return true for an array that has an anyOf or oneOf as its items definition.
This was already the case earlier. Thus, this is not a new behavior but fixes a regression.

Fix #1996

Adapts the `isObjectArrayWithNesting` tester to return true for an array that has an `anyOf` or `oneOf` as its items definition.
This was already the case earlier. Thus, this is not a new behavior but fixes a regression.

Fix eclipsesource#1996

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.356% when pulling d724fae on lucas-koehler:fix-1996-fix-union-types into 0f0470f on eclipsesource:master.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sdirix sdirix merged commit c9e289b into eclipsesource:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rendering of arrays of union types no longer working from 3.0.0-beta.5
3 participants