reset state on prop change for detailList #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes eclipsesource#1977 Signed-off-by: Lukas Boll lukas-bool@web.de
sdirix
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
It's not the best solution as this will lead to an unnecessary render pass (initial pass + the pass with index = undefined) however that's still much better than crashing.
In an ideal solution the index should be determined in the same pass where we determined that schema changed. However this requires some code complexity using useRef etc. So for now the current solution is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1977
Signed-off-by: Lukas Boll lukas-bool@web.de