Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RXJS peer depenency version to include ^7.4.0 #2015

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Conversation

lucas-koehler
Copy link
Contributor

  • Include versions ^7.4.0 into the allowed versions. They are allowed by Angular from 12.2.0 upwards
  • Increase the lower bound of the RXJS 6.x dependency to ^6.5.3 to match Angular's actual requirements
    • Even @angular/core 12.0.0 already requires ^6.5.3
  • Updated package-lock.json generated in dev container

I tested the latest version of rxjs (7.5.6) with rc 1 in the angular seed and did not notice any differences to using the 6.x version

Fixes #2014

* Include versions ^7.4.0 into the allowed versions. They are allowed by Angular from 12.2.0 upwards
* Increase the lower bound of the RXJS 6.x dependency to ^6.5.3 to match Angular's actual requirements
  * Even @angular/core 12.0.0 already requires ^6.5.3
* Updated package-lock.json generated in dev container

Fixes #2014
@coveralls
Copy link

coveralls commented Sep 6, 2022

Coverage Status

Coverage remained the same at 84.356% when pulling 4ca0946 on 2014-rxjs-peer-dep into 852057c on master.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdirix sdirix merged commit d4d47ad into master Sep 21, 2022
@sdirix sdirix deleted the 2014-rxjs-peer-dep branch September 21, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update version of peer dependency RXJS
3 participants