Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added add and remove icons to table renderer fixes #1782 #2021

Merged
merged 4 commits into from
Oct 21, 2022

Conversation

Tarjei400
Copy link
Contributor

Added add and remove icons for Table renderer

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2022

CLA assistant check
All committers have signed the CLA.

@sdirix
Copy link
Member

sdirix commented Sep 21, 2022

Thanks for the contribution ❤️. We will take a look right after the 3.0 release.

@Tarjei400
Copy link
Contributor Author

@sdirix let me know if I can be of any assistance

@coveralls
Copy link

coveralls commented Oct 17, 2022

Coverage Status

Coverage increased (+0.5%) to 84.866% when pulling e773be5 on t3chy0n:master into 79e1c56 on eclipsesource:master.

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tarjei400 Thanks again for the contribution :) The add and remove buttons already work great for me. I added some suggestions regarding the buttons itself. Could you take a look at them please?

packages/angular-material/src/other/table.renderer.ts Outdated Show resolved Hide resolved
packages/angular-material/src/other/table.renderer.ts Outdated Show resolved Hide resolved
packages/angular-material/src/other/table.renderer.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. I just have two minor comments left.

packages/angular-material/src/other/table.renderer.ts Outdated Show resolved Hide resolved
packages/angular-material/src/other/table.renderer.ts Outdated Show resolved Hide resolved
@lucas-koehler lucas-koehler linked an issue Oct 18, 2022 that may be closed by this pull request
Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the updates. LGTM now :)

@lucas-koehler lucas-koehler merged commit 7206141 into eclipsesource:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Add" and "Remove" actions to the Angular Table
5 participants