Fix category hiding in Angular Material #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the Angular Material category renderer didn't consider categories' visbilities and always showed themy. This prefilters visible categories before rendering them in the template. Fix unit test by moving the setting of the new UI schema in the jsonFormsService after it was reassigned in the component. With this, when the event is triggered on the subscription, the new schema is already present. This is necessary for the new changes and also fixes the previously commented out assertion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the Angular Material category renderer didn't consider categories' visbilities and always showed themy.
This prefilters visible categories before rendering them in the template.
Fix unit test by moving the setting of the new UI schema in the jsonFormsService after it was reassigned in the component. With this, when the event is triggered on the subscription, the new schema is already present. This is necessary for the new changes and also fixes the previously commented out assertion.