Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix visibility of error-icon in array #2037

Merged
merged 1 commit into from
Nov 7, 2022
Merged

fix visibility of error-icon in array #2037

merged 1 commit into from
Nov 7, 2022

Conversation

LukasBoll
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.866% when pulling ee840c1 on LukasBoll:fixArrayErrorMessage into 7206141 on eclipsesource:master.

@lucas-koehler lucas-koehler linked an issue Nov 7, 2022 that may be closed by this pull request
Control Error Icon Renders Falsely while screen size is less than 600px #2031
Closed
lucas-koehler
lucas-koehler approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @LukasBoll . I tested it before the fix and could reproduce the error in the development app. With the fix, the issue is gone :)

@lucas-koehler lucas-koehler merged commit 770c78f into eclipsesource:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-koehler lucas-koehler lucas-koehler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Control Error Icon Renders Falsely while screen size is less than 600px
3 participants
@LukasBoll @coveralls @lucas-koehler