Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix duplicate error message #2051

Merged
merged 1 commit into from
Jan 2, 2023
Merged

fix duplicate error message #2051

merged 1 commit into from
Jan 2, 2023

Conversation

LukasBoll
Copy link
Contributor

@LukasBoll LukasBoll commented Nov 14, 2022 •
edited
Loading

subErrorsAt now only returning errors form child elements

closes #1760, closes #1684

@LukasBoll
fix dublicate error message
11f64f2 
subErrorsAt now only returning errors form child elements

closes eclipsesource#1760
@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.38% when pulling 11f64f2 on LukasBoll:errorMessageArray into 91f351d on eclipsesource:master.

@LukasBoll LukasBoll mentioned this pull request Nov 14, 2022
Closed
@sdirix sdirix requested a review from TheZoker November 29, 2022 08:56
TheZoker
TheZoker approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@TheZoker TheZoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems to work with the example from the issue:
image

sdirix
sdirix approved these changes Jan 2, 2023
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sdirix sdirix modified the milestone: 3.1 Jan 2, 2023
@sdirix sdirix changed the title fix dublicate error message fix duplicate error message Jan 2, 2023
@sdirix sdirix merged commit 9f045c4 into eclipsesource:master Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

@TheZoker TheZoker TheZoker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@LukasBoll @coveralls @TheZoker @sdirix