Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix allOf in array #2053

Merged
merged 1 commit into from
Jan 2, 2023
Merged

fix allOf in array #2053

merged 1 commit into from
Jan 2, 2023

Conversation

LukasBoll
Copy link
Contributor

No description provided.

@sdirix sdirix requested a review from TheZoker November 29, 2022 08:56
@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.38% when pulling 3331029 on LukasBoll:fixAllOfInArray into 91f351d on eclipsesource:master.

TheZoker
TheZoker approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@TheZoker TheZoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can confirm that the change work with the example from the issue:
image

sdirix
sdirix approved these changes Jan 2, 2023
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdirix sdirix merged commit 506c098 into eclipsesource:master Jan 2, 2023
@sdirix sdirix linked an issue Jan 2, 2023 that may be closed by this pull request
Custom error message with Ajv-errors on nested schema #2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

@TheZoker TheZoker TheZoker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom error message with Ajv-errors on nested schema
4 participants
@LukasBoll @coveralls @TheZoker @sdirix