Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix toDataPath function comment explaining correct functionality #2061

Merged
merged 1 commit into from
Jan 2, 2023
Merged

fix toDataPath function comment explaining correct functionality #2061

merged 1 commit into from
Jan 2, 2023

Conversation

jlarrubiaq
Copy link
Contributor

I found the explanation of what toDataPath does is not correct. The new comment reflects the actual functionality.

@CLAassistant
Copy link

CLAassistant commented Dec 7, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

sdirix
sdirix requested changes Dec 8, 2022
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

packages/core/src/util/path.ts Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.38% when pulling 557e3a5 on jlarrubiaq:patch-1 into 96be520 on eclipsesource:master.

@jlarrubiaq
Copy link
Contributor Author

@sdirix I addressed your comment. Thanks!

sdirix
sdirix approved these changes Jan 2, 2023
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

@sdirix sdirix added this to the 3.1 milestone Jan 2, 2023
@sdirix sdirix merged commit ef9305a into eclipsesource:master Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@jlarrubiaq @CLAassistant @coveralls @sdirix