Show description or tooltip on boolean controls #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
|
There was a problem hiding this comment.
Hello @brockfanning, thank you very much for your contribution :)
I tested it and it seems to work well.
I have two requests:
- Could you extend one the examples to contain a description for the boolean control. E.g. you could extend packages/examples/src/examples/control-options.ts
- Could you also add this behavior to the MaterialBooleanToggleControl as well? This way both boolean controls behave consistently.
lucas-koehler
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intended behavior here is that if a boolean control has a description, then it will appear as a tooltip. However if showUnfocusedDescription is true, then the description appears below as text. I tried to copy as much code from existing components as possible, but I'm happy to make any changes as needed.