Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundled examples for Angular Material and Vue Vanilla #2074

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

lucas-koehler
Copy link
Contributor

@lucas-koehler lucas-koehler commented Jan 10, 2023

  • Add rollup config to bundle the angular material example
  • Add rollup config to bundle the vue 3 vanilla example
  • Add to examples app

Notes:

Part of #1706

@netlify
Copy link

netlify bot commented Jan 10, 2023

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit acefc00
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/63beca3c364398000861631b
😎 Deploy Preview https://deploy-preview-2074--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lucas-koehler lucas-koehler mentioned this pull request Jan 10, 2023
8 tasks
* Add rollup config to bundle the angular material example
* Add to examples app

Part of #1706
@coveralls
Copy link

coveralls commented Jan 10, 2023

Coverage Status

Coverage: 83.193%. Remained the same when pulling acefc00 on lk/gh-1706/angular-example into 36e3732 on master.

@lucas-koehler
Copy link
Contributor Author

@sdirix I'm a bit confused why the deploy preview link directly links into the angular-material example. So maybe have a look if something unexpected happens here.

* Add rollup config to bundle the Vue Vanilla example
* Add to examples app

Part of #1706
@lucas-koehler lucas-koehler changed the title Add bundled example for Angular Material Add bundled examples for Angular Material and Vue Vanilla Jan 11, 2023
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@sdirix sdirix merged commit 1b22f55 into master Jan 25, 2023
@sdirix sdirix deleted the lk/gh-1706/angular-example branch January 25, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants