Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vue onChange #2084

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Conversation

LukasBoll
Copy link
Contributor

converts additionalError and data to proxy

closes #2003

@netlify
Copy link

netlify bot commented Jan 24, 2023

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit fdb1df2
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/63fdb7bf5a0471000811e644
😎 Deploy Preview https://deploy-preview-2084--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@coveralls
Copy link

coveralls commented Jan 24, 2023

Coverage Status

Coverage: 83.193%. Remained the same when pulling fdb1df2 on LukasBoll:vueOnChange into 3861749 on eclipsesource:master.

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look on first view. However, test test failures of the windows CI are reproducible for me on Ubuntu 22.04 and Node 14 when rebasing the PR on master.
Please rebase and check whether you can reproduce the test failures.

Test failures 1) ArrayListRenderer.vue renders children:
  AssertionError: expected +0 to equal 2
  + expected - actual

  -0
  +2
  
  at Context.<anonymous> (dist/js/webpack:/tests/unit/array/ArrayListRenderer.spec.ts:30:1)
  at processImmediate (internal/timers.js:464:21)
  1. ArrayListRenderer.vue
    add element to array:

    AssertionError: expected [ '' ] to deeply equal [ 'a', 'b', '' ]

    • expected - actual

    [

    • "a"
    • "b"
      ""
      ]

    at Context. (dist/js/webpack:/tests/unit/array/ArrayListRenderer.spec.ts:37:1)

  2. ArrayListRenderer.vue
    remove element from array:
    TypeError: Cannot read property 'trigger' of undefined
    at Context. (dist/js/webpack:/tests/unit/array/ArrayListRenderer.spec.ts:43:1)
    at processImmediate (internal/timers.js:464:21)

  3. ArrayListRenderer.vue
    move element up:
    TypeError: Cannot read property 'trigger' of undefined
    at Context. (dist/js/webpack:/tests/unit/array/ArrayListRenderer.spec.ts:50:1)
    at processImmediate (internal/timers.js:464:21)

  4. ArrayListRenderer.vue
    move element up:
    TypeError: Cannot read property 'trigger' of undefined
    at Context. (dist/js/webpack:/tests/unit/array/ArrayListRenderer.spec.ts:57:1)
    at processImmediate (internal/timers.js:464:21)

  5. BooleanControlRenderer.vue
    emits a data change:

    AssertionError: expected true to equal false

    • expected - actual

    -true
    +false

    at Context. (dist/js/webpack:/tests/unit/controls/BooleanControlRenderer.spec.ts:31:1)

converts additionalError and data to proxy

closes eclipsesource#2003
Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

@lucas-koehler lucas-koehler merged commit 5e8c860 into eclipsesource:master Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event 'change' is triggered twice in Vue from 3.0.0-beta.3
3 participants