-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue/2090 mapStateToCellProps should use translated error messages #2098
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Thanks for the contribution ❤️ Please make sure to sign the CLA in a way which is recognizable by the CLA bot. |
6df47a9
to
37e9e02
Compare
37e9e02
to
780c3d9
Compare
@sdirix , |
d5d3ddc
to
9828188
Compare
@sdirix , Unfortunately, I can't quite figure out why there is a 9828188#diff-7d5366084c8446977a6750222516b31ab17a6b20eda83d02a9ec9848f28cd172L277-L298 I'm pretty sure the Please let me know how you think we should proceed on this one. |
@codefactor Thanks for the work and analysis. We'll take a look 👍 |
@sdirix what are the next steps on this PR? Do you need more test coverage to get it merged? |
This reverts commit 9828188.
Depending on our work load it can take some time until we are able to look at topics like this in detail. The good news is I was able to fix the test ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me!
No description provided.