Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up examples and sort them alphabetically #2101

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Conversation

lucas-koehler
Copy link
Contributor

Examples are now sorted alphabetically by their label.
Improved labels of various examples to better reflect what they contain.

Removed examples:

  • day 1 to day 6: Contain various elements covered in other examples.
  • 1169: Covers specific tester bug, reusable tester is covered by core unit tests.
  • 1220: Old issue from 2.2
  • 1253: Old issue from 2.2, multiple other oneOf examples
  • 1254: Integrated in enum.ts
  • 1645: Performance / debouncing can be tested with the huge example
  • 1996: oneOf part is covered by oneOfArray.ts, anyOf part was integrated in anyOf.ts
  • booleanToggle: Covered in control-options.ts

Renamed examples:

  • 1779.ts -> list-with-detail-primitives.ts
  • stepper.ts -> categorization-stepper.ts
  • steppershownav.ts -> categorization-stepper-nav-buttons.ts
  • dynamic.ts -> generate-dynamic.ts

Part of #1706

Examples are now sorted alphabetically by their label.
Improved labels of various examples to better reflect what they contain.

Removed examples:
- day 1 to day 6: Contain various elements covered in other examples.
- 1169: Covers specific tester bug, reusable tester is covered by core unit tests.
- 1220: Old issue from 2.2
- 1253: Old issue from 2.2, multiple other oneOf examples
- 1254: Integrated in enum.ts
- 1645: Performance / debouncing can be tested with the huge example
- 1996: oneOf part is covered by oneOfArray.ts, anyOf part was integrated in anyOf.ts
- booleanToggle: Covered in control-options.ts

Renamed examples:
- 1779.ts -> list-with-detail-primitives.ts
- stepper.ts -> categorization-stepper.ts
- steppershownav.ts -> categorization-stepper-nav-buttons.ts
- dynamic.ts -> generate-dynamic.ts

Part of #1706
@netlify
Copy link

netlify bot commented Feb 22, 2023

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit a438722
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/63f5fdf8fe0e5e00086cee80
😎 Deploy Preview https://deploy-preview-2101--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@coveralls
Copy link

Coverage Status

Coverage: 83.193%. Remained the same when pulling a438722 on 1706_cleanup-examples into 3861749 on master.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement!

@sdirix sdirix merged commit 229d99a into master Mar 15, 2023
@sdirix sdirix deleted the 1706_cleanup-examples branch March 15, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants