Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

array translatins for vanilla, angular-material and vue #2129

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

LukasBoll
Copy link
Contributor

@LukasBoll LukasBoll commented Apr 11, 2023

Add translation-options for array-control elements for the vanilla, angular-material and vue renderers.

closes #1826

@netlify
Copy link

netlify bot commented Apr 11, 2023

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit f5db5d0
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/643805d1e0da6500088b0f44
😎 Deploy Preview https://deploy-preview-2129--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sdirix
Copy link
Member

sdirix commented Apr 11, 2023

@lucas-koehler Do you have any idea why the Angular Material tests are failing

@LukasBoll
Copy link
Contributor Author

Thank you @lucas-koehler, @sdirix,
I looked at the tests again this afternoon and I just found the issues; A module-import was missing in the testing Module! And the aria-label attribute needs to be assigned another way, then I did. I will update the PR today!

@LukasBoll LukasBoll force-pushed the arrayTranslations branch 2 times, most recently from edf58bd to 4e7b994 Compare April 13, 2023 12:12
Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes in the renderers look already pretty good to me, thanks :)

There are various test cases failing. They are failing consistently on both Windows and Ubuntu. Note that the MacOS build succeeds because it does not execute tests.

It seems that the tests fail because elements are not found. This is likely caused by the changes to the aria labels in packages/core/src/i18n/arrayTranslations.ts because the tests use aria label attributes to find the buttons.
Thus, you need to adapt the tests to the changed aria label texts.

@coveralls
Copy link

Coverage Status

Coverage: 84.703% (+1.5%) from 83.193% when pulling f5db5d0 on LukasBoll:arrayTranslations into ba35fde on eclipsesource:master.

@LukasBoll LukasBoll changed the title WIP: array translatins for vanilla, angular-material and vue array translatins for vanilla, angular-material and vue Apr 13, 2023
@LukasBoll
Copy link
Contributor Author

Code changes in the renderers look already pretty good to me, thanks :)

There are various test cases failing. They are failing consistently on both Windows and Ubuntu. Note that the MacOS build succeeds because it does not execute tests.

It seems that the tests fail because elements are not found. This is likely caused by the changes to the aria labels in packages/core/src/i18n/arrayTranslations.ts because the tests use aria label attributes to find the buttons. Thus, you need to adapt the tests to the changed aria label texts.

Thank you, I just realized that as well, but now everything should work properly!

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks for the fixes :)

@lucas-koehler lucas-koehler merged commit 8b6c9d2 into eclipsesource:master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate hard coded strings in existing renderer sets
4 participants