-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
array translatins for vanilla, angular-material and vue #2129
array translatins for vanilla, angular-material and vue #2129
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@lucas-koehler Do you have any idea why the Angular Material tests are failing |
Thank you @lucas-koehler, @sdirix, |
edf58bd
to
4e7b994
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes in the renderers look already pretty good to me, thanks :)
There are various test cases failing. They are failing consistently on both Windows and Ubuntu. Note that the MacOS build succeeds because it does not execute tests.
It seems that the tests fail because elements are not found. This is likely caused by the changes to the aria labels in packages/core/src/i18n/arrayTranslations.ts
because the tests use aria label attributes to find the buttons.
Thus, you need to adapt the tests to the changed aria label texts.
4e7b994
to
f5db5d0
Compare
Thank you, I just realized that as well, but now everything should work properly! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks for the fixes :)
Add translation-options for array-control elements for the vanilla, angular-material and vue renderers.
closes #1826