fix: properly match AJV paths with slashes #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AJV error paths are JSON Pointers. These paths are converted to dot-notation in JSON Forms. However escaped JSON Pointer characters were not decoded. Therefore errors for properties containing one of the escaped characters were not properly matched. Background information: In JSON Pointers two characters need to be escaped: '~' is converted to '~0' and '/' is converted to '~1'. Therefore properties containing either '~' or '/' were not properly matched to errors before this fix. Fixes eclipsesource#2146
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
LukasBoll
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AJV error paths are JSON Pointers. These paths are converted to dot-notation in JSON Forms. However escaped JSON Pointer characters were not decoded. Therefore errors for properties containing one of the escaped characters were not properly matched.
Background information: In JSON Pointers two characters need to be escaped:
'~'is converted to'~0'and'/'is converted to'~1'. Therefore properties containing either'~'or'/'were not properly matched to errors before this fix.Fixes #2146