Upgrade build stack to pnpm, Node 16, Lerna 6 #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lucas-koehler
commented
Jun 13, 2023
•
lucas-koehler
commented
- Move to Node 16.13+
- Use PNPM 8.5+ as package manager instead of NPM
- Upgrade to Lerna 6
- Explicitly add all needed dependencies to packages as PNPM does not hoist application dependencies
- Use explicit PNPM workspace references for jsonforms packages
- Increase various dependencies to reflect the actually needed versions
- Migrate to Jest 27
- Increase Typedoc version to ~0.21.9 to be compatible with Node 16
- Increase base lib version from ES6 to ES2016
- Improve stability of prepare example apps script
- BREAKING: Remove vue2 to avoid migration cost
- ci: Increase Node's available RAM for test execution to 4GB
- Set pnpm's dependency resolution to highest compatible (same as npm)
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lucas-koehler
force-pushed
the
2110-node16-pnpm-lerna6
branch
from
51938da
to
22f092d
Compare
|
@sdirix The netlify build fails because node 16 and pnpm are not available there, yet. |
lucas-koehler
force-pushed
the
2110-node16-pnpm-lerna6
branch
from
b8578ab
to
d1c5b2e
Compare
|
@sdirix I rebased the changes. Netlify still fails as it does not have pnpm and node 16 configured. |
lucas-koehler
force-pushed
the
2110-node16-pnpm-lerna6
branch
from
d1c5b2e
to
dd97900
Compare
sdirix
reviewed
Jul 7, 2023
|
Seems the mac tests still fail. So let's exclude them again and create a follow up issue to fix them |
- Move to Node 16.13+ - Use PNPM 8.5+ as package manager instead of NPM - Upgrade to Lerna 6 - Explicitly add all needed dependencies to packages as PNPM does not hoist dependencies - Use explicit PNPM workspace references for jsonforms packages - Increase various dependencies as PNPM installs the specified version by default instead of the highest possible one - Migrate to Jest 27 - Increase Typedoc version to ~0.21.9 to be compatible with Node 16 TODO: Fix Setup for the vue packages
- Update dependencies - Directly configure jest with ts-jest in vue package to make tests work
- Core uses Array.includes only contained in ES2016 - ES2016 is supported by all relevant browsers
Adapt path to copy the css theme file to the local node_modules folder created by pnpm
lucas-koehler
force-pushed
the
2110-node16-pnpm-lerna6
branch
from
97ea030
to
a508131
Compare
|
@sdirix I applied your suggestions and rebased the changes. The latest 2 commits are new. |
|
Follow up issue to fix the macOS tests: #2159 |
sdirix
force-pushed
the
2110-node16-pnpm-lerna6
branch
from
e927c4e
to
7a281d7
Compare
This was referenced Jul 11, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.