-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move vue packages up to be directly contained in packages folder; smaller deps improvements #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lucas-koehler
force-pushed
the
2158-vue-packages
branch
from
July 12, 2023 09:11
53b5d96
to
5f020c5
Compare
lucas-koehler
changed the title
Move vue packages up to be directly contained in packages folder
WIP: Move vue packages up to be directly contained in packages folder
Jul 12, 2023
- Move vue packages - Remove obsolete build:pre and build:after scripts from vue-vanilla package - Regenerate pnpm lock file and thereby also update dependencies Fix #2162
Version 3.3.1 of rollup-plugin-import-css was already used. Explicitly raise the dependency because from 3.3.0 the default behavior of generating the bundled css file name changed. Configure example apps to always generate it as bundle.css
lucas-koehler
force-pushed
the
2158-vue-packages
branch
from
August 30, 2023 14:25
83ed649
to
16c8bd8
Compare
karma-webpack is meant for webpack 3 while we use webpack 4 in this package.
v2 is outdated and is implemented for legacy Node 12.
lucas-koehler
force-pushed
the
2158-vue-packages
branch
from
August 30, 2023 14:46
16c8bd8
to
fd486fc
Compare
lucas-koehler
changed the title
WIP: Move vue packages up to be directly contained in packages folder
Move vue packages up to be directly contained in packages folder, smaller deps improvements
Aug 30, 2023
lucas-koehler
changed the title
Move vue packages up to be directly contained in packages folder, smaller deps improvements
Move vue packages up to be directly contained in packages folder; smaller deps improvements
Aug 30, 2023
sdirix
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sdirix
pushed a commit
that referenced
this pull request
Sep 1, 2023
- Move vue packages - Remove obsolete build:pre and build:after scripts from vue-vanilla package - Regenerate pnpm lock file and thereby also update dependencies Fix #2162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2158