Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

angular-material: Fix unfocused description display for number renderer #2167

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

lucas-koehler
Copy link
Contributor

The template had a bug closing the ngIf that checks whether the description is shown too early. This lead to a DOMException and the description to never be shown.

Fix #2166

The template had a bug closing the ngIf that checks whether the description
is shown too early. This lead to a DOMException and the description to never be shown.

Fix #2166
@netlify
Copy link

netlify bot commented Jul 27, 2023

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit e97e03b
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/64c24858473007000860fc3a
😎 Deploy Preview https://deploy-preview-2167--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 84.254%. remained the same when pulling e97e03b on 2166-angular-number-renderer-bug into 071b320 on master.

@lucas-koehler lucas-koehler merged commit e80a873 into master Jul 27, 2023
@lucas-koehler lucas-koehler deleted the 2166-angular-number-renderer-bug branch July 27, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR DOMException in browser console
3 participants