-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make material renderers aware of input variant in theme #2182
Make material renderers aware of input variant in theme #2182
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
0c5f106
to
38fc730
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sebastianfrey
Thank you very much for the contribution ❤️
The changes already look pretty good to me and worked well in the example app!
Besides the small remarks inline, I have one question:
Could we make handing in InputComponent
to the controls optional and fall back to material's Input
? With this, we would not break custom renderers that use these controls. Do you think that makes sense?
packages/material-renderers/src/mui-controls/MuiInputInteger.tsx
Outdated
Show resolved
Hide resolved
packages/material-renderers/src/mui-controls/MuiInputNumber.tsx
Outdated
Show resolved
Hide resolved
Hi @lucas-koehler,
Let me know if anything else is missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sebastianfrey
Thank you for the updates! I have just one remaining small comment inline.
packages/material-renderers/src/controls/MaterialInputControl.tsx
Outdated
Show resolved
Hide resolved
1ad814e
to
67cf64e
Compare
Hi @lucas-koehler, Your requested change should be fixed now. After browsing through the example forms, I have noticed that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. Thanks again for the contribution and the updates :)
Hi @lucas-koehler, Is there the possibility to publish a pre-release version for this PR? |
Hi @sebastianfrey , |
@lucas-koehler Ok thanks, no rush here please! |
Hi @sebastianfrey , we released |
@lucas-koehler Thank you very much! |
@lucas-koehler do you have an ETA for the |
Hi @MikeyZat , our current plan is to publish a |
Resolves #1797.
This PR makes material renderers aware of the input variant defined in the global MUI theme.
The example app was enhanced with a select, which allows to change the input variant.