-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update @mui/icons-material depdency in material-renderers #2218
update @mui/icons-material depdency in material-renderers #2218
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sorry if I'm missing something super obvious - I basically just changed the |
Hi @devbydaniel ,
Thus, my suggestion is to revert all changes that don't update mui, emotion or dayjs. What do you think? |
Thanks for you reply! I actually tried to change only the packages necessary for updating the version of material-icons. I changed the And just to be sure - I tried to build a test application from Thanks for your patience anyway :) |
Hi @devbydaniel , I just tried to build on master and the normal build ( My suggestion would be to revert back to master, then clean the repository with |
@lucas-koehler Thanks again for your help, I think / hope I got it right this time! |
Hi @devbydaniel , thanks for the update. It seems correct but I'd like that we also make the |
@lucas-koehler done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution :)
change dependency of @mui/icons-material in material-renderers from
~5.11.16
to^5.11.16