Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove @jsonforms/angular-test peerDependency #2230

Merged

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented Dec 15, 2023

The @jsonforms/angular-material package specified
@jsonforms/angular-test as peerDependency. This is now removed.

The @jsonforms/angular-material package specified
@jsonforms/angular-test as peerDependency. This is now removed.
Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit b670a40
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/657c879f36e9a500080d1aa2
😎 Deploy Preview https://deploy-preview-2230--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 83.078%. remained the same
when pulling b670a40 on sdirix:remove-angular-test-dependency
into da46b98 on eclipsesource:master.

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@lucas-koehler lucas-koehler merged commit a7d3268 into eclipsesource:master Dec 18, 2023
8 checks passed
@sdirix sdirix deleted the remove-angular-test-dependency branch January 30, 2024 10:34
@sdirix sdirix added this to the 3.2 milestone Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants