fix(material): consistently use outlined input variant #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LukasBoll
force-pushed
the
fix/material_outlineed
branch
from
3d8eed5
to
2a52cb4
Compare
sdirix
reviewed
Jan 24, 2024
MIGRATION.md
Outdated
|
|
||
| ### Material Renderers using Outlined Inputs | ||
|
|
||
| JSON Forms has been updated to use the `outlined` input variant as the default, aligning more closely with the default style of Material UI. |
There was a problem hiding this comment.
Suggested change
| JSON Forms has been updated to use the `outlined` input variant as the default, aligning more closely with the default style of Material UI. | |
| JSON Forms now uses the `outlined` input variant as the default, aligning with the default style of Material UI since version 5. |
MIGRATION.md
Outdated
| ### Material Renderers using Outlined Inputs | ||
|
|
||
| JSON Forms has been updated to use the `outlined` input variant as the default, aligning more closely with the default style of Material UI. | ||
| To use the `standard` input variant, as in previous versions of JSON Forms, it is possible to provide JSON Forms with a theme provider: |
There was a problem hiding this comment.
Suggested change
| To use the `standard` input variant, as in previous versions of JSON Forms, it is possible to provide JSON Forms with a theme provider: | |
| If you would like to use the `standard` input variant, as was default in previous versions of JSON Forms, then this can be accomplished using the Material UI `ThemeProvider`: |
Use outlined input variant as the default to match Material UI
LukasBoll
force-pushed
the
fix/material_outlineed
branch
from
2a52cb4
to
0b5b756
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use outlined input variant as the default to match Material UI