Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: fix the React Material and Vanilla example dev setup #2257

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented Jan 24, 2024

We recently updated Typescript. The new version is incompatible to our (pretty old) webpack dev-server setup.

We now update Webpack throughout the whole repository, fixing the webpack dev-server setup in the process.

We recently updated Typescript. The new version is incompatible to our
(pretty old) webpack dev-server setup.

We now update Webpack throughout the whole repository, fixing the
webpack dev-server setup in the process.
Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 78423dd
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/65b10005719eb800094f3449
😎 Deploy Preview https://deploy-preview-2257--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 84.796%. remained the same
when pulling 78423dd on sdirix:fix-dev-server-setup
into 1791e5c on eclipsesource:master.

Copy link
Contributor

@LukasBoll LukasBoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, all dev applications are working again!

@sdirix sdirix merged commit 442742e into eclipsesource:master Jan 24, 2024
8 checks passed
@sdirix sdirix deleted the fix-dev-server-setup branch January 24, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants