Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update migration guide and readmes #2258

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented Jan 24, 2024

  • remove the 3.0 migration warning from @jsonforms/core
  • add more information to migration guide in regards to Angular 16/17
  • update JSON Forms component props information in all binding readmes

- remove the 3.0 migration warning from @jsonforms/core
- add more information to migration guide in regards to Angular 16/17
- update JSON Forms component props information in all binding readmes
Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit a4c7655
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/65b121623b9e180008358c34
😎 Deploy Preview https://deploy-preview-2258--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Jan 24, 2024

Coverage Status

coverage: 84.796%. remained the same
when pulling a4c7655 on sdirix:update-migration-and-readmes
into 442742e on eclipsesource:master.

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks. I only have two minor grammar improvement suggestions.

MIGRATION.md Outdated Show resolved Hide resolved
MIGRATION.md Outdated Show resolved Hide resolved
sdirix and others added 2 commits January 24, 2024 15:40
Co-authored-by: Lucas Koehler <lkoehler@eclipsesource.com>
Co-authored-by: Lucas Koehler <lkoehler@eclipsesource.com>
@sdirix sdirix merged commit d791185 into eclipsesource:master Jan 24, 2024
8 checks passed
@sdirix sdirix deleted the update-migration-and-readmes branch January 24, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants