Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: add simple grid layout to the dev app. save example name at location hash. show schema and uischema #2269

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

davewwww
Copy link
Contributor

@davewwww davewwww commented Feb 5, 2024

i also stored the selected example at the location hash. and i have added the schema and uischema.

Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 1a2ada7
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/65c1f86aba805500088cd80d
😎 Deploy Preview https://deploy-preview-2269--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sdirix
Copy link
Member

sdirix commented Feb 6, 2024

Thanks for this contribution ❤️ We will take a look soon 👍

@coveralls
Copy link

Coverage Status

coverage: 84.796%. remained the same
when pulling 1a2ada7 on davewwww:dev-app-with-grid-layout
into e06f5e8 on eclipsesource:master.

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @davewwww , thanks for this great improvement of the dev/example app ❤️ The changes LGTM!

@lucas-koehler lucas-koehler merged commit 0cec549 into eclipsesource:master Feb 13, 2024
8 checks passed
@lucas-koehler lucas-koehler added this to the 3.3 milestone Feb 13, 2024
@davewwww davewwww deleted the dev-app-with-grid-layout branch February 13, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants