Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable auto select in MuiAutocomplete control #2276

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

lukasf
Copy link
Contributor

@lukasf lukasf commented Feb 10, 2024

The MUI Autoselect control currently has a weird behavior, which can easily lead to accidential selections or selection changes, when the user just wants to "light dismiss" the dropdown. See issue #2232.

This PR fixes the irritating behavior by removing the "autoSelect" property.

Copy link

netlify bot commented Feb 10, 2024

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit d9d929a
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/65c74cfc2430830008cfb9bf
😎 Deploy Preview https://deploy-preview-2276--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant
Copy link

CLAassistant commented Feb 10, 2024

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

coverage: 84.796%. remained the same
when pulling d9d929a on lukasf:fix-autoselect
into 5c6806f on eclipsesource:master.

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@lucas-koehler lucas-koehler merged commit ce541c5 into eclipsesource:master Feb 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete control (React MUI) accidentally selects when click outside
4 participants