Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core/testers): add hasOption tester #2287

Merged
merged 2 commits into from
Feb 19, 2024
Merged

feat(core/testers): add hasOption tester #2287

merged 2 commits into from
Feb 19, 2024

Conversation

zaosoula
Copy link
Contributor

@zaosoula zaosoula commented Feb 17, 2024 •
edited
Loading

This PR adds a tester name hasOption allowing to check the presence of an option without specifying its value

@CLAassistant
Copy link

CLAassistant commented Feb 17, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify Netlify
Copy link

netlify bot commented Feb 17, 2024 •
edited
Loading

✅ Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 6cee939
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/65d36cd7f44fcf000897a05d
😎 Deploy Preview https://deploy-preview-2287--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sdirix
sdirix approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the contribution

packages/core/src/testers/testers.ts Outdated Show resolved Hide resolved
@zaosoula @sdirix
chore: linting
6cee939 
Co-authored-by: Stefan Dirix <sdirix@eclipsesource.com>
@coveralls
Copy link

coveralls commented Feb 19, 2024 •
edited
Loading

Coverage Status

coverage: 84.861% (+0.07%) from 84.796%
when pulling 6cee939 on ezyostudio:master
into 072caa5 on eclipsesource:master.

@sdirix sdirix merged commit 51b63f5 into eclipsesource:master Feb 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zaosoula @CLAassistant @coveralls @sdirix