-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React MUI : MaterialEnumArrayRenderer - Add Form Label and description #2297
React MUI : MaterialEnumArrayRenderer - Add Form Label and description #2297
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ce-enum-label-description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Maxouwell , thanks a lot for another contribution ❤️
The code looks already pretty good to me and showing the labels and description works well in the example :)
I just have two small remarks inline. Please have a look.
packages/material-renderers/src/complex/MaterialEnumArrayRenderer.tsx
Outdated
Show resolved
Hide resolved
packages/material-renderers/src/complex/MaterialEnumArrayRenderer.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks ✨
PR for #2296. with always on label (not conditionnal to an option)