Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React MUI : MaterialEnumArrayRenderer - Add Form Label and description #2297

Conversation

Maxouwell
Copy link
Contributor

PR for #2296. with always on label (not conditionnal to an option)

Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit e32cbae
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/65e1cc0cb6e2880008d34c88
😎 Deploy Preview https://deploy-preview-2297--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Mar 1, 2024

Coverage Status

coverage: 84.881% (+0.008%) from 84.873%
when pulling e32cbae on Maxouwell:feature/mui-react-multi-choice-enum-label-description
into 21dd591 on eclipsesource:master.

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Maxouwell , thanks a lot for another contribution ❤️
The code looks already pretty good to me and showing the labels and description works well in the example :)
I just have two small remarks inline. Please have a look.

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks ✨

@lucas-koehler lucas-koehler merged commit 30c1b79 into eclipsesource:master Mar 1, 2024
8 checks passed
@Maxouwell Maxouwell deleted the feature/mui-react-multi-choice-enum-label-description branch March 1, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React MUI : MaterialEnumArrayRenderer - Add Form Label and description
3 participants