Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation fix and support of elementLabelProp to ListWithDetail #2304

Merged

Conversation

Maxouwell
Copy link
Contributor

@Maxouwell Maxouwell commented Mar 20, 2024

Based on #2289 PR

Fix some translation issues on MUI ListWithDetail component and add support for the elementLabelProp option (including translation of enum and oneOf values introduced by #2289)

Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 13fa9c5
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/66213fab9e0d670008a85021
😎 Deploy Preview https://deploy-preview-2304--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Maxouwell Maxouwell changed the title Fix/list with details translated labels Add translation fix and support of elementLabelProp to ListWithDetail Mar 20, 2024
@Maxouwell Maxouwell force-pushed the fix/ListWithDetails-translated-labels branch 2 times, most recently from 6d7e775 to 6303134 Compare March 25, 2024 16:10
@coveralls
Copy link

coveralls commented Mar 27, 2024

Coverage Status

coverage: 83.347% (+0.08%) from 83.269%
when pulling 13fa9c5 on Maxouwell:fix/ListWithDetails-translated-labels
into a672127 on eclipsesource:master.

@Maxouwell Maxouwell marked this pull request as ready for review April 18, 2024 15:09
@sdirix sdirix force-pushed the fix/ListWithDetails-translated-labels branch from 7ee0f71 to 187b614 Compare April 18, 2024 15:14
@sdirix sdirix merged commit e1724a8 into eclipsesource:master Apr 18, 2024
8 checks passed
@Maxouwell Maxouwell deleted the fix/ListWithDetails-translated-labels branch April 18, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants