-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update ID on schema change #2307
fix: update ID on schema change #2307
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This commit will update the IDs of all controls if the schema prop handed over to JSON Forms changes. closes eclipsesource#2213
61e3822
to
65b252b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LukasBoll , thanks for the update :) Generally the changes now look good to me. Is there a reason that this PR is still marked as a draft?
Hi @lucas-koehler , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LukasBoll Alright makes sense. I also tested with the vue example app and switching between the person and scope examples successfully updated the id even when removing the key in the example app. Without this fix, this did not work.
This commit will update the IDs of all controls if the schema prop handed over to JSON Forms changes.
closes #2213